linux-kernel - Re: [PATCH v3 3/5] i2c: exynos5: Remove suspension check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABYn4swJfYhTbXA0zYG4Mncm2xSGjL8CQPyeEB_piQWE+wUyTA@mail.gmail.com>
Date:	Thu, 17 Jul 2014 18:54:10 +0200
From:	Bastian Hecht <hechtb@...il.com>
To:	linux-i2c@...r.kernel.org
Cc:	Linux-SH <linux-sh@...r.kernel.org>,
	Tomoya MORINAGA <tomoya.rohm@...il.com>,
	Wolfram Sang <wsa@...-dreams.de>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Bastian Hecht <hechtb@...il.com>,
	Kukjin Kim <kgene.kim@...sung.com>,
	Naveen Krishna Ch <ch.naveen@...sung.com>,
	Jingoo Han <jg1.han@...sung.com>,
	Jean Delvare <jdelvare@...e.de>,
	Linus Walleij <linus.walleij@...aro.org>,
	Masanari Iida <standby24x7@...il.com>,
	Sachin Kamat <sachin.kamat@...aro.org>,
	"moderated list:ARM/S5P EXYNOS AR..." 
	<linux-samsung-soc@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 3/5] i2c: exynos5: Remove suspension check

2014-07-17 16:48 GMT+02:00 Bastian Hecht <hechtb@...il.com>:
> We now take care of suspension in the i2c core code. So we can remove this
> check here.
>
> Signed-off-by: Bastian Hecht <hechtb@...il.com>
> ---
> same as v1
>
>  drivers/i2c/busses/i2c-exynos5.c | 20 +-------------------
>  1 file changed, 1 insertion(+), 19 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-exynos5.c b/drivers/i2c/busses/i2c-exynos5.c
> index 63d2292..a80cf28 100644
> --- a/drivers/i2c/busses/i2c-exynos5.c
> +++ b/drivers/i2c/busses/i2c-exynos5.c
> @@ -145,7 +145,6 @@
>
>  struct exynos5_i2c {
>         struct i2c_adapter      adap;
> -       unsigned int            suspended:1;
>
>         struct i2c_msg          *msg;
>         struct completion       msg_complete;
> @@ -610,11 +609,6 @@ static int exynos5_i2c_xfer(struct i2c_adapter *adap,
>         struct exynos5_i2c *i2c = adap->algo_data;
>         int i = 0, ret = 0, stop = 0;
>
> -       if (i2c->suspended) {
> -               dev_err(i2c->dev, "HS-I2C is not initialized.\n");
> -               return -EIO;
> -       }
> -
>         clk_prepare_enable(i2c->clk);
>
>         for (i = 0; i < num; i++, msgs++) {
> @@ -757,16 +751,6 @@ static int exynos5_i2c_remove(struct platform_device *pdev)
>  }
>
>  #ifdef CONFIG_PM_SLEEP
> -static int exynos5_i2c_suspend_noirq(struct device *dev)
> -{
> -       struct platform_device *pdev = to_platform_device(dev);
> -       struct exynos5_i2c *i2c = platform_get_drvdata(pdev);
> -
> -       i2c->suspended = 1;
> -
> -       return 0;
> -}
> -
>  static int exynos5_i2c_resume_noirq(struct device *dev)
>  {
>         struct platform_device *pdev = to_platform_device(dev);
> @@ -783,14 +767,12 @@ static int exynos5_i2c_resume_noirq(struct device *dev)
>
>         exynos5_i2c_init(i2c);
>         clk_disable_unprepare(i2c->clk);
> -       i2c->suspended = 0;
>
>         return 0;
>  }
>  #endif
>
> -static SIMPLE_DEV_PM_OPS(exynos5_i2c_dev_pm_ops, exynos5_i2c_suspend_noirq,
> -                        exynos5_i2c_resume_noirq);
> +static SIMPLE_DEV_PM_OPS(exynos5_i2c_dev_pm_ops, exynos5_i2c_resume_noirq);

This should be

+static SIMPLE_DEV_PM_OPS(exynos5_i2c_dev_pm_ops, NULL,
exynos5_i2c_resume_noirq);

And this is v2, not v3.

>  static struct platform_driver exynos5_i2c_driver = {
>         .probe          = exynos5_i2c_probe,
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/