linux-kernel - Re: [PATCH 2/2] perf, x86: Don't mark DataLA addresses as store

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABPqkBSY=zJKCoran4psjm3uo1ozQfM0sG1Uff_=Ro-uPZLwVg@mail.gmail.com>
Date:	Thu, 17 Jul 2014 22:24:44 +0200
From:	Stephane Eranian <eranian@...gle.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Andi Kleen <ak@...ux.intel.com>, Andi Kleen <andi@...stfloor.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] perf, x86: Don't mark DataLA addresses as store

On Tue, Jul 15, 2014 at 8:19 PM, Stephane Eranian <eranian@...gle.com> wrote:
> On Tue, Jul 15, 2014 at 10:59 AM, Peter Zijlstra <peterz@...radead.org> wrote:
>> On Mon, Jul 14, 2014 at 09:05:42PM -0700, Andi Kleen wrote:
>>
>>> Yes, there are only three store events:
>>>
>>> MEM_UOPS_RETIRED.STLB_MISS_STORES
>>> MEM_UOPS_RETIRED.SPLIT_STORES
>>> MEM_UOPS_RETIRED.ALL_STORES
>>>
>>> These can be added.
>>>
>>> But most others are loads, so if you wanted loads too (besides mem-loads)
>>> it would be nearly a full list.
>>
>> Of that list you had earlier:
>>
>> MEM_UOPS_RETIRED.STLB_MISS_LOADS
>> MEM_UOPS_RETIRED.STLB_MISS_STORES
>> MEM_UOPS_RETIRED.LOCK_LOADS
>> MEM_UOPS_RETIRED.SPLIT_LOADS
>> MEM_UOPS_RETIRED.SPLIT_STORES
>> MEM_UOPS_RETIRED.ALL_LOADS
>> MEM_UOPS_RETIRED.ALL_STORES
>>
>> There's only 4 loads and (as you already said) 3 stores.
>>
>> That's 7 events total, that's not nearly a full list.
>>
>> The other events:
>>
>> UOPS_RETIRED.ALL
>> MEM_LOAD_UOPS_RETIRED.L1_HIT
>> MEM_LOAD_UOPS_RETIRED.L2_HIT
>> MEM_LOAD_UOPS_RETIRED.L3_HIT
>> MEM_LOAD_UOPS_RETIRED.L1_MISS
>> MEM_LOAD_UOPS_RETIRED.L2_MISS
>> MEM_LOAD_UOPS_RETIRED.L3_MISS
>> MEM_LOAD_UOPS_RETIRED.HIT_LFB
>> MEM_LOAD_UOPS_L3_HIT_RETIRED.XSNP_MISS
>> MEM_LOAD_UOPS_L3_HIT_RETIRED.XSNP_HIT
>> MEM_LOAD_UOPS_L3_HIT_RETIRED.XSNP_HITM
>> MEM_LOAD_UOPS_L3_HIT_RETIRED.XSNP_NONE
>> MEM_LOAD_UOPS_L3_MISS_RETIRED.LOCAL_DRAM
>>
> Those are loads uops.
>
I suggest we add those back as loads. We cannot really loose
precision in the info returned.

>> are unclear on their type and should indeed be NA.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/