linux-kernel - Re: [PATCH] checkpatch.pl: Remove --file option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140718135612.GA18432@roeck-us.net>
Date:	Fri, 18 Jul 2014 06:56:12 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Richard Weinberger <richard@....at>
Cc:	Borislav Petkov <bp@...e.de>, akpm@...ux-foundation.org,
	apw@...onical.com, joe@...ches.com, tytso@....edu,
	dwalter@...gle.com, neilb@...e.de, hch@...radead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch.pl: Remove --file option

On Fri, Jul 18, 2014 at 03:46:29PM +0200, Richard Weinberger wrote:
> Am 18.07.2014 15:37, schrieb Guenter Roeck:
> > On 07/18/2014 01:23 AM, Borislav Petkov wrote:
> >> On Fri, Jul 18, 2014 at 12:29:37AM -0700, Guenter Roeck wrote:
> >>> First, 'abuse' is a relative term. It describes a use you
> >>> (and possibly many others) may find objectionable, but that
> >>> does not mean all uses are objectionable.
> >>
> >> Do you actually have a valid use case for keeping the cmdline switch ...
> >>
> > 
> > I find it convenient to be able to check a new file before committing it
> > and creating a patch. Also, I find it convenient to be able use it to clean
> > up a file before I do heavy lifting with it. Yes, I understand the latter
> > is discouraged nowadays, and I would not use it anymore outside my scope
> > of responsibility unless specifically asked by the maintainer to do so,
> > but in such cases it helps me a lot to be able to address the cleanup
> > prior to the heavy lifting.
> 
> As capable kernel hacker you can still use a command like:
> diff -urN /dev/null $file | ./scripts/checkpatch.pl -
> 

Yes, that came up before. Or I can revert the patch locally, or keep an old
version of checkpatch around. You make me suffer because someone else abuses
the system. That someone will find other ways to abuse the system, such as
using the same approach, or annoy you with something else, such as searching
for "fixme" statements in the code or sending unhelpful emails about failing
builds. The one thing you will not accomplish is to solve the problem.

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/