linux-kernel - Re: [PATCH] checkpatch.pl: Remove --file option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53C92C86.2030408@metafoo.de>
Date:	Fri, 18 Jul 2014 16:17:42 +0200
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Richard Weinberger <richard@....at>, akpm@...ux-foundation.org
CC:	apw@...onical.com, joe@...ches.com, tytso@....edu,
	dwalter@...gle.com, bp@...e.de, neilb@...e.de, hch@...radead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch.pl: Remove --file option

On 07/17/2014 05:34 PM, Richard Weinberger wrote:
[...]
> In order to deal with that bad habit let's remove the --file option
> and bring checkpatch.pl back to its original purpose.

I don't think this is a good solution the problem and I'm not sure how 
successful it will actually be at fixing the problem. How about instead 
properly documenting that single line trivial style cleanup patches are not 
really helpful and people should not send them? (Maybe add a check to 
checkpatch.pl that emits a warning if the patch is a trivial style cleanup ;))

--file is a in my opinion useful option and at least I use it on a regular 
basis.

- Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/