linux-kernel - Re: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140718151039.GA7425@infradead.org>
Date:	Fri, 18 Jul 2014 08:10:39 -0700
From:	"Christoph Hellwig (hch@...radead.org)" <hch@...radead.org>
To:	KY Srinivasan <kys@...rosoft.com>
Cc:	Jens Axboe <axboe@...nel.dk>,
	James Bottomley <jbottomley@...allels.com>,
	"michaelc@...wisc.edu" <michaelc@...wisc.edu>,
	"Christoph Hellwig (hch@...radead.org)" <hch@...radead.org>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"jasowang@...hat.com" <jasowang@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"ohering@...e.com" <ohering@...e.com>,
	"apw@...onical.com" <apw@...onical.com>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>
Subject: Re: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from
 the basic I/O timeout

On Thu, Jul 17, 2014 at 11:53:33PM +0000, KY Srinivasan wrote:
> I still see this problem. There was talk of fixing it elsewhere.

Well, what we have right not is entirely broken, given that the
block layer doesn't initialize ->timeout on TYPE_FS requeuests.

We either need to revert that initial commit or apply something like
the attached patch as a quick fix.


View attachment "0001-sd-set-a-non-zero-timeout-for-flush-requests.patch" of type "text/plain" (837 bytes)