linux-kernel - Re: [PATCH] spi: omap2-mcspi: fix blatant abuse of the resource subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140718171035.GQ17528@sirena.org.uk>
Date:	Fri, 18 Jul 2014 18:10:35 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Lothar Waßmann <LW@...O-electronics.de>
Cc:	linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	Benoit Cousson <bcousson@...libre.com>,
	Shubhrajyoti D <shubhrajyoti@...com>,
	Charulatha V <charu@...com>
Subject: Re: [PATCH] spi: omap2-mcspi: fix blatant abuse of the resource
 subsystem

On Fri, Jul 18, 2014 at 01:30:53PM +0200, Lothar Waßmann wrote:
> Aua. This really hurts. I wonder how this could ever be admitted to
> the Linux kernel...
> Further comments suppressed because the would most likely violate the
> CDA.
> 
> If someone should not grasp what this patch does, they should consider
> what happens upon unloading/reloading the kernel module.
> 
> Signed-off-by: Lothar Waßmann <LW@...O-electronics.de>

I'm not going to apply this with a commit message such as the above.
Quite aside from the tone the fact that it doesn't describe the issue
is not helpful for review, one of the things done in review is to try to
check that the change has the intended effect.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)