lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140721075144.251bb67d@ipc1.ka-ro> Date: Mon, 21 Jul 2014 07:51:44 +0200 From: Lothar Waßmann <LW@...O-electronics.de> To: Mark Brown <broonie@...nel.org> Cc: linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, Benoit Cousson <bcousson@...libre.com>, Shubhrajyoti D <shubhrajyoti@...com>, Charulatha V <charu@...com> Subject: Re: [PATCH] spi: omap2-mcspi: fix blatant abuse of the resource subsystem Hi, Mark Brown wrote: > On Fri, Jul 18, 2014 at 01:30:53PM +0200, Lothar Waßmann wrote: > > Aua. This really hurts. I wonder how this could ever be admitted to > > the Linux kernel... > > Further comments suppressed because the would most likely violate the > > CDA. > > > > If someone should not grasp what this patch does, they should consider > > what happens upon unloading/reloading the kernel module. > > > > Signed-off-by: Lothar Waßmann <LW@...O-electronics.de> > > I'm not going to apply this with a commit message such as the above. > Quite aside from the tone the fact that it doesn't describe the issue > is not helpful for review, one of the things done in review is to try to > check that the change has the intended effect. > Maybe the original author or the maintainer who accepted this can come up with a decent fix for this. Lothar Waßmann -- ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info@...o-electronics.de ___________________________________________________________ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists