linux-kernel - Re: [PATCH 02/10] nohz: Kick full dynticks timer targets with an empty IPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140719071951.GS9918@twins.programming.kicks-ass.net>
Date:	Sat, 19 Jul 2014 09:19:51 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...nel.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Viresh Kumar <viresh.kumar@...aro.org>
Subject: Re: [PATCH 02/10] nohz: Kick full dynticks timer targets with an
 empty IPI

On Sat, Jul 19, 2014 at 02:44:13AM +0200, Frederic Weisbecker wrote:
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 7f3063c..f3e48b8 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -693,7 +693,7 @@ static bool wake_up_full_nohz_cpu(int cpu)
>  	if (tick_nohz_full_cpu(cpu)) {
>  		if (cpu != smp_processor_id() ||
>  		    tick_nohz_tick_stopped())
> -			tick_nohz_full_kick_cpu(cpu);
> +			irq_work_void_on(cpu);

So no, while the previous function name was descriptive, the new one
leave one wondering.

Content of type "application/pgp-signature" skipped