linux-kernel - Re: [PATCH] drivers: i2c: i2c-st: Update i2c timings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53CCF3EC.6030904@st.com>
Date:	Mon, 21 Jul 2014 13:05:16 +0200
From:	Maxime Coquelin <maxime.coquelin@...com>
To:	Wolfram Sang <wsa@...-dreams.de>
Cc:	<linux-i2c@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Srinivas Kandagatla <srinivas.kandagatla@...il.com>,
	Patrice Chotard <patrice.chotard@...com>, <kernel@...inux.com>
Subject: Re: [PATCH] drivers: i2c: i2c-st: Update i2c timings

Hi Wolfram,

On 06/03/2014 09:59 AM, Wolfram Sang wrote:
> 
>>> Can you give names here? Would be interesting to know since a few
>>> drivers implement the minimum timings.
>>
>> I don't have the name actually.
>> The request to implement this change came from hw guys.
> 
> Can you ask? It feels better to have changes based on facts.

Sorry for the late reply, but it took time to get the answer.

Apparently the HDMI link of the Toshiba 19AV600U TV is affected by this.
I have no references of other devices (if any).

> 
>>>> This patch adds a 10% margin on all the timings.
>>>
>>> Is there a safety margin or do the devices start to work exactly at 10%?
>>
>> 10% is a safety margin, I don't know what is the limit.
> 
> Which also came from the HW guys? Please ask for details why 10%, too.

This is a safety margin.
Note that the I2C specification only defines minimal timings.

Is it fine for you?
Can I re-send a v2, which:
 - Indicate the Toshiba TV is one of the affected devices in the commit message
 - Indicate the 10% margin is a safety one in the commit message
 - Add a comment above the table indicating these are standard timings + 10% margin.

Regards,
Maxime

> 
> Thanks,
> 
>     Wolfram
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/