linux-kernel - Re: [PATCH 2/2] perf, x86: Don't mark DataLA addresses as store

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABPqkBQvtZ0Joc6nZOVp4Pt0Bh4=m8gw+_sVbdY9qMYD55YQOQ@mail.gmail.com>
Date:	Mon, 21 Jul 2014 23:15:01 +0200
From:	Stephane Eranian <eranian@...gle.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	Andi Kleen <ak@...ux.intel.com>,
	Peter Zijlstra <peterz@...radead.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] perf, x86: Don't mark DataLA addresses as store

On Sat, Jul 19, 2014 at 2:49 AM, Andi Kleen <andi@...stfloor.org> wrote:
> On Tue, Jul 15, 2014 at 12:49:43AM +0200, Stephane Eranian wrote:
>> On Tue, Jul 15, 2014 at 12:39 AM, Andi Kleen <ak@...ux.intel.com> wrote:
>> >> I have a problem with this patch.
>> >>
>> >> It makes: perf mem -t store rec record OP_NA for the store.
>> >> It was recording OP_STORE before.
>> >>
>> >> I think we need to keep LD/ST info. This is useful for analysis
>> >> especially if we collect loads/stores simultaneously.
>> >>
>> >> Was working before for the mem-loads, mem-stores events.
>> >
>> > Ok. Would it be enough if it only worked for "mem-stores" and not
>> > all PEBS events?
>> >
>> Ok, do that at a minimum.
>
> I fixed it now. However it turned out that "perf mem report"
> actually not report mem_op, only mem_lvl.
>
> You may want to fix that separately.
>
It is because it currently record loads or store but not both simultaneously.
Once I allow load/store in a single run, it will print the mem_op.

> -Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/