linux-kernel - Re: [PATCH] PCI/AER: Forward declare struct pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140721232732.GA4736@shangw>
Date:	Tue, 22 Jul 2014 09:27:32 +1000
From:	Gavin Shan <gwshan@...ux.vnet.ibm.com>
To:	Tuomas Tynkkynen <ttynkkynen@...dia.com>
Cc:	Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI/AER: Forward declare struct pci_dev to avoid warning

On Mon, Jul 21, 2014 at 07:30:43PM +0300, Tuomas Tynkkynen wrote:

I guess it's same issue and fix as:

http://patchwork.ozlabs.org/patch/370629/

Thanks,
Gavin

>Forward declaring struct pci_dev in aer.h avoids this warning:
>
>In file included from include/ras/ras_event.h:11:0,
>                 from drivers/ras/ras.c:13:
>include/linux/aer.h:38:44: warning: 'struct pci_dev’ declared inside parameter list [enabled by default]
>include/linux/aer.h:38:44: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
>
>Signed-off-by: Tuomas Tynkkynen <ttynkkynen@...dia.com>
>---
> include/linux/aer.h | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/include/linux/aer.h b/include/linux/aer.h
>index 4dbaa70..d9ec8dd 100644
>--- a/include/linux/aer.h
>+++ b/include/linux/aer.h
>@@ -7,6 +7,8 @@
> #ifndef _AER_H_
> #define _AER_H_
>
>+struct pci_dev;
>+
> #define AER_NONFATAL			0
> #define AER_FATAL			1
> #define AER_CORRECTABLE			2
>-- 
>1.8.1.5
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-pci" in
>the body of a message to majordomo@...r.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/