lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140722114320.GB18750@titan.lakedaemon.net> Date: Tue, 22 Jul 2014 07:43:20 -0400 From: Jason Cooper <jason@...edaemon.net> To: Herbert Xu <herbert@...dor.apana.org.au> Cc: Amit Shah <amit.shah@...hat.com>, linux-kernel@...r.kernel.org, Virtualization List <virtualization@...ts.linux-foundation.org>, Rusty Russell <rusty@...tcorp.com.au>, keescook@...omium.org, Amos Kong <akong@...hat.com> Subject: Re: [PATCH v2 3/4] virtio: rng: delay hwrng_register() till driver is ready On Mon, Jul 21, 2014 at 08:41:24PM +0800, Herbert Xu wrote: > On Mon, Jul 21, 2014 at 08:11:16AM -0400, Jason Cooper wrote: > > > > > @@ -136,15 +137,6 @@ static int probe_common(struct virtio_device *vdev) > > > return err; > > > } > > > > > > - err = hwrng_register(&vi->hwrng); > > > - if (err) { > > > - vdev->config->del_vqs(vdev); > > > - vi->vq = NULL; > > > - kfree(vi); > > > - ida_simple_remove(&rng_index_ida, index); > > > - return err; > > > - } > > > - > > > > This needs to stay. register, and failure to do so, should occur in the > > probe routine. > > Why? hmm, yes. On reviewing the code, my objection was silly. It mostly stemmed from the commit message's mentioning of reduced error handling. thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists