linux-kernel - Re: [PATCH v2 0/4] virtio-rng: contribute to early randomness requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140722114623.GC18750@titan.lakedaemon.net>
Date:	Tue, 22 Jul 2014 07:46:23 -0400
From:	Jason Cooper <jason@...edaemon.net>
To:	Amit Shah <amit.shah@...hat.com>
Cc:	linux-kernel@...r.kernel.org,
	Virtualization List <virtualization@...ts.linux-foundation.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	herbert@...dor.apana.org.au, keescook@...omium.org,
	Amos Kong <akong@...hat.com>
Subject: Re: [PATCH v2 0/4] virtio-rng: contribute to early randomness
 requests

On Mon, Jul 21, 2014 at 05:15:48PM +0530, Amit Shah wrote:
> v2:
>  - update patch 3 to store the hwrng_register_done bool per-device
>    rather than global
>  - add patch 2 that re-arranges struct elems for better packing.
> 
> Hi,
> 
> This series enables virtio-rng to service the early randomness
> requests made by the hwrng core (patch 3), with Herbert's idea of
> using the scan routine.
> 
> Patch 4 reverts the previous restriction, which no longer applies, to
> not send read requests to the host before successful probe.
> 
> Patches 1 and 2 are minor cleanups.
> 
> Please review and apply,
> 
> Amit Shah (4):
>   virtio: rng: remove unused struct element
>   virtio: rng: re-arrange struct elements for better packing
>   virtio: rng: delay hwrng_register() till driver is ready
>   Revert "hwrng: virtio - ensure reads happen after successful probe"
> 
>  drivers/char/hw_random/core.c       |  6 ------
>  drivers/char/hw_random/virtio-rng.c | 39 ++++++++++++++++---------------------
>  2 files changed, 17 insertions(+), 28 deletions(-)

fwiw,

Reviewed-by: Jason Cooper <jason@...edaemon.net>

Thanks for putting this together Amit!

thx,

Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/