linux-kernel - Re: [PATCH 09/19] mfd: ezx-pcap: Repair coding style errors picked up with checkpatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 22 Jul 2014 06:33:58 -0700
From:	Joe Perches <joe@...ches.com>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	sameo@...ux.intel.com
Subject: Re: [PATCH 09/19] mfd: ezx-pcap: Repair coding style errors picked
 up with checkpatch

On Tue, 2014-07-22 at 12:11 +0100, Lee Jones wrote:
> This is part of an effort to clean-up the MFD subsystem.
> 
> WARNING: Missing a blank line after declarations
> +       u32 flags;
> +       void (*callback)(void *, u16[]);

False positive from an old version of checkpatch.

The one in -next doesn't emit this as it's
simply a function pointer declaration.

> diff --git a/drivers/mfd/ezx-pcap.c b/drivers/mfd/ezx-pcap.c
[]
> @@ -25,8 +25,9 @@ struct pcap_adc_request {
>  	u8 bank;
>  	u8 ch[2];
>  	u32 flags;
> -	void (*callback)(void *, u16[]);
>  	void *data;
> +
> +	void (*callback)(void *, u16[]);
>  };


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/