lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 22 Jul 2014 14:48:24 +0100 From: Lee Jones <lee.jones@...aro.org> To: Joe Perches <joe@...ches.com> Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, sameo@...ux.intel.com Subject: Re: [PATCH 09/19] mfd: ezx-pcap: Repair coding style errors picked up with checkpatch On Tue, 22 Jul 2014, Joe Perches wrote: > On Tue, 2014-07-22 at 12:11 +0100, Lee Jones wrote: > > This is part of an effort to clean-up the MFD subsystem. > > > > WARNING: Missing a blank line after declarations > > + u32 flags; > > + void (*callback)(void *, u16[]); > > False positive from an old version of checkpatch. > > The one in -next doesn't emit this as it's > simply a function pointer declaration. Thanks Joe, will fix up. > > diff --git a/drivers/mfd/ezx-pcap.c b/drivers/mfd/ezx-pcap.c > [] > > @@ -25,8 +25,9 @@ struct pcap_adc_request { > > u8 bank; > > u8 ch[2]; > > u32 flags; > > - void (*callback)(void *, u16[]); > > void *data; > > + > > + void (*callback)(void *, u16[]); > > }; > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists