linux-kernel - Re: [PATCH 2/2 V2] workqueue: remove the argument @wakeup from worker_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140722143824.GC13851@htj.dyndns.org>
Date:	Tue, 22 Jul 2014 10:38:24 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Lai Jiangshan <laijs@...fujitsu.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2 V2] workqueue: remove the argument @wakeup from
 worker_set_flags()

On Tue, Jul 22, 2014 at 01:02:00PM +0800, Lai Jiangshan wrote:
> worker_set_flags() doesn't necessarily wake next worker and the @wakeup
> can be removed, the caller can use the following conbination instead
> when needed:
> 
> 	worker_set_flags();
> 	if (need_more_worker(pool))
>  		wake_up_worker(pool);
> 
> It reduces the machine-code and footprint for the process_one_work()
> if worker_set_flags() is really inlined.
> 
> Signed-off-by: Lai Jiangshan <laijs@...fujitsu.com>

Applied 1-2 to wq/for-3.17 w/ descriptions and comments updated.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/