lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CALFYKtDo0ivvYWhjAKJs-LiBRQfrxeN8QAQ1QPX4aswb0+VkWw@mail.gmail.com> Date: Tue, 22 Jul 2014 22:32:10 +0400 From: Ilya Dryomov <ilya.dryomov@...tank.com> To: Himangi Saraogi <himangi774@...il.com> Cc: Alex Elder <elder@...nel.org>, Ceph Development <ceph-devel@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Julia Lawall <julia.lawall@...6.fr> Subject: Re: [PATCH] rbd: Use kmem_cache_free On Tue, Jul 22, 2014 at 10:11 PM, Himangi Saraogi <himangi774@...il.com> wrote: > Free memory allocated using kmem_cache_zalloc using kmem_cache_free > rather than kfree. > > The Coccinelle semantic patch that makes this change is as follows: > > // <smpl> > @@ > expression x,E,c; > @@ > > x = \(kmem_cache_alloc\|kmem_cache_zalloc\|kmem_cache_alloc_node\)(c,...) > ... when != x = E > when != &x > ?-kfree(x) > +kmem_cache_free(c,x) > // </smpl> > > Signed-off-by: Himangi Saraogi <himangi774@...il.com> > Acked-by: Julia Lawall <julia.lawall@...6.fr> > --- > drivers/block/rbd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c > index b2c98c1..8381c54 100644 > --- a/drivers/block/rbd.c > +++ b/drivers/block/rbd.c > @@ -1158,7 +1158,7 @@ static const char *rbd_segment_name(struct rbd_device *rbd_dev, u64 offset) > if (ret < 0 || ret > CEPH_MAX_OID_NAME_LEN) { > pr_err("error formatting segment name for #%llu (%d)\n", > segment, ret); > - kfree(name); > + kmem_cache_free(rbd_segment_name_cache, name); > name = NULL; > } We seem to have a helper for this, rbd_segment_name_free(). Care to resend? Thanks, Ilya -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists