lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <53CEAE0F.9080901@ti.com> Date: Tue, 22 Jul 2014 13:31:43 -0500 From: Nishanth Menon <nm@...com> To: <balbi@...com>, Tony Lindgren <tony@...mide.com> CC: Rob Herring <robh+dt@...nel.org>, Mark Rutland <mark.rutland@....com>, Benoit Cousson <bcousson@...libre.com>, <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org> Subject: Re: [PATCH] pinctrl: dra: dt-bindings: Fix pull enable/disable On 07/22/2014 11:47 AM, Felipe Balbi wrote: > On Tue, Jul 22, 2014 at 10:39:54AM -0500, Nishanth Menon wrote: >> The DRA74/72 control module pins have a weak pull up and pull down. >> This is configured by bit offset 17. if BIT(17) is 1, a pull up is >> selected, else a pull down is selected. >> >> However, this pull resisstor is applied based on BIT(16) - >> PULLUDENABLE - if BIT(18) is *0*, then pull as defined in BIT(17) is >> applied, else no weak pulls are applied. We defined this in reverse. >> >> Reference: Table 18-5 (Description of the pad configuration register >> bits) in Technical Reference Manual Revision (DRA74x revision Q: >> SPRUHI2Q Revised June 2014 and DRA72x revision F: SPRUHP2F - Revised >> June 2014) >> >> Fixes: 6e58b8f1daaf1a ("ARM: dts: DRA7: Add the dts files for dra7 SoC and dra7-evm board") >> Signed-off-by: Nishanth Menon <nm@...com> >> --- > > Tested on an upcoming board. > > Tested-by: Felipe Balbi <balbi@...com> > Acked-by: Felipe Balbi <balbi@...com> > > Felipe, Thanks. Tony, If you could consider this for the rc cycle it might be great(as well as for stable). The pull direction error can cause all kinds of Pull-down Vs Pull-Up contention with severe risk for certain IP reliability. -- Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists