linux-kernel - Re: [PATCH v5 0/3] APEI: Make APEI architecture independent.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+8MBb+KuKaeXr5p97xWZKJB7T-NAooi-kXQTaPx0QnO53-oCQ@mail.gmail.com>
Date:	Tue, 22 Jul 2014 14:08:58 -0700
From:	Tony Luck <tony.luck@...il.com>
To:	Tomasz Nowicki <tomasz.nowicki@...aro.org>
Cc:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Len Brown <lenb@...nel.org>, Borislav Petkov <bp@...en8.de>,
	"m.chehab@...sung.com" <m.chehab@...sung.com>,
	Borislav Petkov <bp@...e.de>, rric@...nel.org,
	Linux Edac Mailing List <linux-edac@...r.kernel.org>,
	X86-ML <x86@...nel.org>, linux-acpi <linux-acpi@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linaro-acpi@...ts.linaro.org
Subject: Re: [PATCH v5 0/3] APEI: Make APEI architecture independent.

On Tue, Jul 22, 2014 at 2:20 AM, Tomasz Nowicki
<tomasz.nowicki@...aro.org> wrote:
> APEI is currently implemented so that it depends on x86 hardware.
> The primary dependency is that GHES uses the x86 NMI for hardware
> error notification and MCE for memory error handling. These patches
> remove that dependency.
>
> Other APEI features such as error reporting via external IRQ, error
> serialization, or error injection, do not require changes to use them
> on non-x86 architectures.
>
> The following patch set eliminates the APEI Kconfig x86 dependency
> by making these changes:
> - treat NMI notification as GHES architecture - HAVE_ACPI_APEI_NMI
> - group and wrap around #ifdef CONFIG_HAVE_ACPI_APEI_NMI code which
>   is used only for NMI path
> - identify architectural boxes and abstract it accordingly (tlb flush and MCE)
> - rework ioremap for both IRQ and NMI context
>
> NMI code is kept in ghes.c file since NMI and IRQ context are tightly coupled.
>
> Note, these patches introduce no functional changes for x86. The NMI notification
> feature is hard selected for x86. Architectures that want to use this
> feature should also provide NMI code infrastructure.

Looks OK to me. I've thrown this series into a topic branch of the ras
git tree named "apei".  When I push it to kernel.org in a few minutes
the build test robots will pounce and try all sorts of randconfig builds.
They'll send you (and me) e-mails if they find any corner cases.

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/