linux-kernel - Re: [Xen-devel] [PATCH] xen/pciback: Fix error return code in xen_pcibk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 23 Jul 2014 14:01:17 +0100
From:	"Jan Beulich" <JBeulich@...e.com>
To:	<weiyj_lk@....com>, "David Vrabel" <david.vrabel@...rix.com>,
	"Boris Ostrovsky" <boris.ostrovsky@...cle.com>,
	"Konrad Rzeszutek Wilk" <konrad.wilk@...cle.com>
Cc:	<xen-devel@...ts.xenproject.org>,
	"Wei Yongjun" <yongjun_wei@...ndmicro.com.cn>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [Xen-devel] [PATCH] xen/pciback: Fix error return code in
 xen_pcibk_attach()

>>> On 20.07.14 at 07:46, <weiyj_lk@....com> wrote:
> --- a/drivers/xen/xen-pciback/xenbus.c
> +++ b/drivers/xen/xen-pciback/xenbus.c
> @@ -174,6 +174,7 @@ static int xen_pcibk_attach(struct xen_pcibk_device *pdev)
>  				 "version mismatch (%s/%s) with pcifront - "
>  				 "halting " DRV_NAME,
>  				 magic, XEN_PCI_MAGIC);
> +		err = -EFAULT;
>  		goto out;
>  	}
>  

While -EFAULT is kind of odd here, I realize this is because the same
also gets passed to xenbus_dev_fatal(); -EILSEQ, -ENODATA, or
-EPROTO (despite it normally being network specific) would seem
better to me.

In any event
Reviewed-by Jan Beulich <jbeulich@...e.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/