linux-kernel - Re: [PATCH 52/52] perf tools: Add support for 32-bit compatibility VDSOs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140723130215.GC1207@krava.brq.redhat.com>
Date:	Wed, 23 Jul 2014 15:02:15 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Adrian Hunter <adrian.hunter@...el.com>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	linux-kernel@...r.kernel.org, David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Namhyung Kim <namhyung@...il.com>,
	Paul Mackerras <paulus@...ba.org>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 52/52] perf tools: Add support for 32-bit compatibility
 VDSOs

On Tue, Jul 22, 2014 at 04:18:01PM +0300, Adrian Hunter wrote:
> 'perf record' post-processes the event stream  to create
> a list of build-ids for object files for which sample
> events have been recorded.  That results in those object
> files being recorded in the build-id cache.

SNIP

>  
>  	if (vdso_info->vdso.found)
>  		unlink(vdso_info->vdso.temp_file_name);
> +#if BITS_PER_LONG == 64
> +	if (vdso_info->vdso32.found)
> +		unlink(vdso_info->vdso.temp_file_name);
> +	if (vdso_info->vdsox32.found)
> +		unlink(vdso_info->vdso.temp_file_name);
> +#endif
>  
>  	zfree(&machine->vdso_info);
>  }
> @@ -135,6 +159,143 @@ static struct dso *vdso__new(struct machine *machine, const char *short_name,
>  	return dso;
>  }
>  
> +#if BITS_PER_LONG == 64

Does this define mean all 64 archs? Do we want other than x86 in here?
(all of its instances)

jirka

> +
> +static enum dso_type machine__thread_dso_type(struct machine *machine,
> +					      struct thread *thread)
> +{
> +	enum dso_type dso_type = DSO__TYPE_UNKNOWN;
> +	struct map *map;
> +	struct dso *dso;
> +
> +	map = map_groups__first(thread->mg, MAP__FUNCTION);
> +	for (; map ; map = map_groups__next(map)) {
> +		dso = map->dso;
> +		if (!dso || dso->long_name[0] != '/')
> +			continue;
> +		dso_type = dso__type(dso, machine);
> +		if (dso_type != DSO__TYPE_UNKNOWN)
> +			break;
> +	}
> +
> +	return dso_type;
> +}

SNIP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/