linux-kernel - Re: [PATCH] regulator: drivers: fix return value of get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53D0D5B5.6010904@nvidia.com>
Date:	Thu, 24 Jul 2014 15:15:25 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	Mark Brown <broonie@...nel.org>,
	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
CC:	"milo.kim@...com" <milo.kim@...com>,
	"support.opensource@...semi.com" <support.opensource@...semi.com>,
	"patches@...nsource.wolfsonmicro.com" 
	<patches@...nsource.wolfsonmicro.com>,
	"lgirdwood@...il.com" <lgirdwood@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] regulator: drivers: fix return value of get_mode callback

Hi Mark
On Monday 14 July 2014 11:31 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Mon, Jul 14, 2014 at 12:57:18PM +0100, Charles Keepax wrote:
>> On Mon, Jul 14, 2014 at 04:03:17PM +0530, Laxman Dewangan wrote:
> It's because it's returning something defined as a bitmask, though since
> we don't even have enough modes for 8 bits that's not really a strong
> reason and we should just be returning an error code as everyone is
> clearly already assuming we do.
>
Just to confirm, do you want to change the return type of get_mode() to 
"int" instead of
unsigned int? And then return proper error type?

In this case I think it should be single patch (core + driver).

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/