linux-kernel - Re: [PATCH] regulator: drivers: fix return value of get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140725175135.GD17528@sirena.org.uk>
Date:	Fri, 25 Jul 2014 18:51:35 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>,
	"milo.kim@...com" <milo.kim@...com>,
	"support.opensource@...semi.com" <support.opensource@...semi.com>,
	"patches@...nsource.wolfsonmicro.com" 
	<patches@...nsource.wolfsonmicro.com>,
	"lgirdwood@...il.com" <lgirdwood@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] regulator: drivers: fix return value of get_mode callback

On Thu, Jul 24, 2014 at 03:15:25PM +0530, Laxman Dewangan wrote:
> On Monday 14 July 2014 11:31 PM, Mark Brown wrote:
> >On Mon, Jul 14, 2014 at 12:57:18PM +0100, Charles Keepax wrote:
> >>On Mon, Jul 14, 2014 at 04:03:17PM +0530, Laxman Dewangan wrote:

> >It's because it's returning something defined as a bitmask, though since
> >we don't even have enough modes for 8 bits that's not really a strong
> >reason and we should just be returning an error code as everyone is
> >clearly already assuming we do.

> Just to confirm, do you want to change the return type of get_mode() to
> "int" instead of
> unsigned int? And then return proper error type?

Yes.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)