linux-kernel - Re: [PATCH 04/15] Input: atmel_mxt_ts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53D12E74.5070508@wwwdotorg.org>
Date:	Thu, 24 Jul 2014 10:04:04 -0600
From:	Stephen Warren <swarren@...dotorg.org>
To:	Nick Dyer <nick.dyer@...ev.co.uk>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:	Yufeng Shen <miletus@...gle.com>,
	Daniel Kurtz <djkurtz@...omium.org>,
	Henrik Rydberg <rydberg@...omail.se>,
	Joonyoung Shim <jy0922.shim@...sung.com>,
	Alan Bowens <Alan.Bowens@...el.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	Peter Meerwald <pmeerw@...erw.net>,
	Benson Leung <bleung@...omium.org>,
	Olof Johansson <olofj@...omium.org>,
	Sekhar Nori <nsekhar@...com>,
	Stephen Warren <swarren@...dia.com>
Subject: Re: [PATCH 04/15] Input: atmel_mxt_ts - implement device tree support

On 07/24/2014 09:10 AM, Nick Dyer wrote:
> On 23/07/14 22:36, Stephen Warren wrote:
>> Hmm. It looks like the version of this patch that was actually applied
>> varies quite a bit from what was posted, in particular in the
>> implementation and call site of mxt_parse_dt(). It'd be nice if the
>> commit log had been adjusted to mention this, so it didn't look like *I*
>> caused all those compile errors and warnings that the 0-day builder just
>> found:-(
> 
> Apologies for my part in this. It doesn't help that this patch went through
> several revisions. Is there a best practice for when to remove
> signed-off-by or change authorship documented anywhere?

My comment was more directed at the diff between what you posted and
what was applied.

I believe the usual practice is:

* If completely re-writing a patch using another as inspiration, change
the author and credit them in free-form text, or perhaps with a
Based-on-work-by: tag.

* If generally keeping the patch, but just changing a few things, make a
note of it in between the s-o-b lines, e.g.:

Signed-off-by: Stephen Warren <swarren@...dia.com>
Signed-off-by: Nick Dyer <nick.dyer@...ev.co.uk>
[assign directly to pdata->t19_keymap to avoid a temporary, description
of other changes ...]
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/