lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 24 Jul 2014 16:11:52 -0400 From: Benjamin Tissoires <benjamin.tissoires@...hat.com> To: Dmitry Torokhov <dmitry.torokhov@...il.com> Cc: Jiri Kosina <jkosina@...e.cz>, Ping Cheng <pinglinux@...il.com>, Jason Gerecke <killertofu@...il.com>, Przemo Firszt <przemo@...szt.eu>, linux-kernel@...r.kernel.org, linux-input@...r.kernel.org Subject: Re: [PATCH v2 07/10] Input - wacom: handle Graphire BT tablets in wacom.ko On Jul 24 2014 or thereabouts, Dmitry Torokhov wrote: > On Thu, Jul 24, 2014 at 03:43:52PM -0400, Benjamin Tissoires wrote: > > On Jul 24 2014 or thereabouts, Dmitry Torokhov wrote: > > > Hi Benjamin, > > > > > > On Thu, Jul 24, 2014 at 02:14:02PM -0400, Benjamin Tissoires wrote: > > > > + } else if (features->type == GRAPHIRE_BT) { > > > > + /* Compute distance between mouse and tablet */ > > > > + rw = 44 - (data[6] >> 2); > > > > + if (rw < 0) > > > > + rw = 0; > > > > + else if (rw > 31) > > > > + rw = 31; > > > > > > rw = clamp_val(rw, 0, 31); > > > > > > ? > > > > could be... > > > > I'll do the tests and resubmit later the v3. I'll wait a little in case > > you have other comments on the other patches :) > > How about doing it incrementally - the patch is still sound as far as I > am concerned. I will wait a bit for other to chime in with comments or > acks before applying this series. > As you want. Just making the exact changes you mentioned still makes the Graphire working (what a surprise, isn't it?). So I am fine either way. Cheers, Benjamin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists