linux-kernel - Re: [patch] mm, thp: restructure thp avoidance of light synchronous migration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53D60F31.4050504@suse.cz>
Date:	Mon, 28 Jul 2014 10:52:01 +0200
From:	Vlastimil Babka <vbabka@...e.cz>
To:	David Rientjes <rientjes@...gle.com>,
	Andrew Morton <akpm@...ux-foundation.org>
CC:	Mel Gorman <mgorman@...e.de>, Rik van Riel <riel@...hat.com>,
	Johannes Weiner <hannes@...xchg.org>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [patch] mm, thp: restructure thp avoidance of light synchronous
 migration

On 07/25/2014 12:41 AM, David Rientjes wrote:
> __GFP_NO_KSWAPD, once the way to determine if an allocation was for thp or not,
> has gained more users.  Their use is not necessarily wrong, they are trying to
> do a memory allocation that can easily fail without disturbing kswapd, so the
> bit has gained additional usecases.
>
> This restructures the check to determine whether MIGRATE_SYNC_LIGHT should be
> used for memory compaction in the page allocator.  Rather than testing solely
> for __GFP_NO_KSWAPD, test for all bits that must be set for thp allocations.
>
> This also moves the check to be done only after the page allocator is aborted
> for deferred or contended memory compaction since setting migration_mode for
> this case is pointless.
>
> Signed-off-by: David Rientjes <rientjes@...gle.com>
> ---
>   mm/page_alloc.c | 17 +++++++++--------
>   1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -2616,14 +2616,6 @@ rebalance:
>   		goto got_pg;
>
>   	/*
> -	 * It can become very expensive to allocate transparent hugepages at
> -	 * fault, so use asynchronous memory compaction for THP unless it is
> -	 * khugepaged trying to collapse.
> -	 */
> -	if (!(gfp_mask & __GFP_NO_KSWAPD) || (current->flags & PF_KTHREAD))
> -		migration_mode = MIGRATE_SYNC_LIGHT;
> -
> -	/*
>   	 * If compaction is deferred for high-order allocations, it is because
>   	 * sync compaction recently failed. In this is the case and the caller
>   	 * requested a movable allocation that does not heavily disrupt the
> @@ -2633,6 +2625,15 @@ rebalance:
>   						(gfp_mask & __GFP_NO_KSWAPD))
>   		goto nopage;
>
> +	/*
> +	 * It can become very expensive to allocate transparent hugepages at
> +	 * fault, so use asynchronous memory compaction for THP unless it is
> +	 * khugepaged trying to collapse.
> +	 */
> +	if ((gfp_mask & GFP_TRANSHUGE) != GFP_TRANSHUGE ||
> +						(current->flags & PF_KTHREAD))
> +		migration_mode = MIGRATE_SYNC_LIGHT;
> +

Looks like kind of a shotgun approach to me. A single __GFP_NO_KSWAPD 
bullet is no longer enough, so we use all the flags and hope for the 
best. It seems THP has so many flags it should be unique for now, but I 
wonder if there is a better way to say how much an allocation is willing 
to wait.

>   	/* Try direct reclaim and then allocating */
>   	page = __alloc_pages_direct_reclaim(gfp_mask, order,
>   					zonelist, high_zoneidx,
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@...ck.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@...ck.org"> email@...ck.org </a>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/