linux-kernel - Re: [PATCH] hwrng: Pass entropy to add_hwgenerator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140728094929.GJ972@lst.de>
Date:	Mon, 28 Jul 2014 11:49:29 +0200
From:	Torsten Duwe <duwe@....de>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	Theodore Ts'o <tytso@....edu>, linux-kernel@...r.kernel.org,
	Matt Mackall <mpm@...enic.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	"H . Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] hwrng: Pass entropy to add_hwgenerator_randomness() in
	bits, not bytes

On Fri, Jul 25, 2014 at 03:19:18PM -0700, Stephen Boyd wrote:
> rng_get_data() returns the number of bytes read from the hardware.
> The entropy argument to add_hwgenerator_randomness() is passed
> directly to credit_entropy_bits() so we should be passing the
> number of bits, not bytes here.

Absolutely correct.

Acked-by: Torsten Duwe <duwe@...e.de>

> Fixes: be4000bc464 "hwrng: create filler thread"
> Cc: Torsten Duwe <duwe@...e.de>
> Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>
> ---
>  drivers/char/hw_random/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
> index dc80cdab733d..6e02ec103cc7 100644
> --- a/drivers/char/hw_random/core.c
> +++ b/drivers/char/hw_random/core.c
> @@ -362,7 +362,7 @@ static int hwrng_fillfn(void *unused)
>  			continue;
>  		}
>  		add_hwgenerator_randomness((void *)rng_fillbuf, rc,
> -					   (rc*current_quality)>>10);
> +					   rc * current_quality * 8 >> 10);
>  	}
>  	hwrng_fill = NULL;
>  	return 0;
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> hosted by The Linux Foundation
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/