linux-kernel - Re: [PATCH] hwrng: Pass entropy to add_hwgenerator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140805222303.GB26399@thunk.org>
Date:	Tue, 5 Aug 2014 18:23:03 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Torsten Duwe <duwe@....de>
Cc:	Stephen Boyd <sboyd@...eaurora.org>, linux-kernel@...r.kernel.org,
	Matt Mackall <mpm@...enic.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	"H . Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] hwrng: Pass entropy to add_hwgenerator_randomness() in
 bits, not bytes

On Mon, Jul 28, 2014 at 11:49:29AM +0200, Torsten Duwe wrote:
> On Fri, Jul 25, 2014 at 03:19:18PM -0700, Stephen Boyd wrote:
> > rng_get_data() returns the number of bytes read from the hardware.
> > The entropy argument to add_hwgenerator_randomness() is passed
> > directly to credit_entropy_bits() so we should be passing the
> > number of bits, not bytes here.
> 
> Absolutely correct.
> 
> Acked-by: Torsten Duwe <duwe@...e.de>

Applied, thanks.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/