linux-kernel - Re: [PATCH 22/27] perf tools: Enable --children option by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8738dkirlt.fsf@sejong.aot.lge.com>
Date:	Tue, 29 Jul 2014 15:52:46 +0900
From:	Namhyung Kim <namhyung@...il.com>
To:	Andres Freund <andres@...razel.de>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Jiri Olsa <jolsa@...hat.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Andi Kleen <andi@...stfloor.org>, Arun Sharma <asharma@...com>,
	Rodrigo Campos <rodrigo@...g.com.ar>,
	Don Zickus <dzickus@...hat.com>
Subject: Re: [PATCH 22/27] perf tools: Enable --children option by default

Hi Andres,

On Mon, 28 Jul 2014 21:23:26 +0200, Andres Freund wrote:
> Hi,
>
> On 2014-05-29 12:58:25 +0900, Namhyung Kim wrote:
>> Now perf top and perf report will show children column by default if
>> it has callchain information.
>> 
>> Requested-by: Ingo Molnar <mingo@...nel.org>
>> Tested-by: Rodrigo Campos <rodrigo@...g.com.ar>
>> Tested-by: Arun Sharma <asharma@...com>
>> Acked-by: Jiri Olsa <jolsa@...hat.com>
>> Cc: Frederic Weisbecker <fweisbec@...il.com>
>> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
>
> Stupid question: Why? This breaks user's usage pattern in a rather
> significant way because the new output is pretty much entirely useless
> in many cases, especially for userland programs. I think the new option
> is great, but why is it suddenly the default?

Yes, I knew it'd annoy some existing users like you :)  But I hoped it'd
be useful for new and (at least, some of) old users to see children/
cumulative overheads by default.  If it lies under an option, it
wouldn't have a chance to be used by normal users who simply run perf
record and report most of time.

If you think it's entirely useless for you cases, you can set it to off
using ~/.perfconfig file:

  [report]
  children = false


Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/