linux-kernel - Re: [PATCH] staging: dgnc: remove commented code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 29 Jul 2014 11:18:57 +0200
From:	Tobias Klauser <tklauser@...tanz.ch>
To:	Seunghun Lee <waydi1@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	Lidza Louina <lidza.louina@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: dgnc: remove commented code

On 2014-07-25 at 18:49:01 +0200, Seunghun Lee <waydi1@...il.com> wrote:
> This patch removes commented code in dgnc driver.
> 
> CC: Lidza Louina <lidza.louina@...il.com>
> CC: Mark Hounschell <markh@...pro.net>
> Signed-off-by: Seunghun Lee <waydi1@...il.com>
> ---
>  drivers/staging/dgnc/dgnc_cls.c   |    5 +-
>  drivers/staging/dgnc/dgnc_trace.c |  123 -------------------------------------
>  drivers/staging/dgnc/dgnc_trace.h |   10 ---
>  drivers/staging/dgnc/dgnc_tty.c   |   18 ------
>  drivers/staging/dgnc/digi.h       |    1 -
>  5 files changed, 1 insertion(+), 156 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
> index 8e265c2..4b65306 100644
> --- a/drivers/staging/dgnc/dgnc_cls.c
> +++ b/drivers/staging/dgnc/dgnc_cls.c
> @@ -1046,10 +1046,7 @@ static void cls_flush_uart_read(struct channel_t *ch)
>  	 * I believe this is a BUG in this UART.
>  	 * So for now, we will leave the code #ifdef'ed out...
>  	 */

The comment above relates to the deleted code, so it should be updated
accordingly.

> -#if 0
> -	writeb((UART_FCR_ENABLE_FIFO | UART_FCR_CLEAR_RCVR),
> -					 &ch->ch_cls_uart->isr_fcr);
> -#endif
> +
>  	udelay(10);
>  }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/