linux-kernel - Re: [PATCH 1/1] drivers: staging: vt6655: ioctl.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140729091751.GB4856@mwanda>
Date:	Tue, 29 Jul 2014 12:17:51 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Tobias Klauser <tklauser@...tanz.ch>
Cc:	Anil Belur <askb23@...il.com>, devel@...verdev.osuosl.org,
	gregkh@...uxfoundation.org, silvio.fricke@...il.com,
	linux-kernel@...r.kernel.org, bjorn@...k.no
Subject: Re: [PATCH 1/1] drivers: staging: vt6655: ioctl.c - missing __user
 annotation

On Tue, Jul 29, 2014 at 10:05:38AM +0200, Tobias Klauser wrote:
> On 2014-07-28 at 09:58:12 +0200, Anil Belur <askb23@...il.com> wrote:
> > From: Anil Belur <askb23@...il.com>
> > 
> > - private_ioctl() the internally calls copy_{to,from}_user() and does
> >   not use '__user' while refrencing user space pointers.
> > - this patch passes __user annotation as a cast, when the pointer is
> >  being refernced.
> 
> Wouldn't it be better to annotate the data member in struct tagSCmdRequest
> with __user instead of introducing all these casts?

Don't ask rhetorical questions on email lists.  Just be blunt.

These casts are not the correct fix.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/