linux-kernel - Re: [PATCH 1/1] drivers: staging: vt6655: ioctl.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53D859A3.1010607@gmail.com>
Date:	Wed, 30 Jul 2014 08:04:11 +0530
From:	Anil Shashikumar Belur <askb23@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>,
	Tobias Klauser <tklauser@...tanz.ch>
CC:	devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
	silvio.fricke@...il.com, linux-kernel@...r.kernel.org,
	bjorn@...k.no
Subject: Re: [PATCH 1/1] drivers: staging: vt6655: ioctl.c - missing __user
 annotation


On Tuesday 29 July 2014 02:47 PM, Dan Carpenter wrote:
> On Tue, Jul 29, 2014 at 10:05:38AM +0200, Tobias Klauser wrote:
>
>> Wouldn't it be better to annotate the data member in struct tagSCmdRequest
>> with __user instead of introducing all these casts?

Hi,

Yes, having the data member annotated as '__user' in 'struct
tagSCmdRequest' looks like a much cleaner way for fixing these warnings.
I will re-work on this patch this patch and submit again.

Thanks,
Anil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/