linux-kernel - Re: [RFC/PATCH] perf tools: Check recorded kernel version when finding vmlinux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87tx5zhh21.fsf@sejong.aot.lge.com>
Date:	Wed, 30 Jul 2014 08:38:14 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	David Ahern <dsahern@...il.com>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	Jiri Olsa <jolsa@...hat.com>, Minchan Kim <minchan@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>
Subject: Re: [RFC/PATCH] perf tools: Check recorded kernel version when finding vmlinux

Hi David,

On Tue, 29 Jul 2014 09:14:54 -0600, David Ahern wrote:
> On 7/29/14, 2:15 AM, Namhyung Kim wrote:
>> This requires to change signature of symbol__init() to receive struct
>> perf_session_env *.  This patch only does some trivial changes - some
>
> Why only pass the env for perf-report? Why not for any command
> analyzing a file? So for live commands env is NULL meaning use host
> paths; for recorded files pass env from session header and use it
> (plus symbol settings like symfs).

Yes, it needs other changes like you said.  But I'd like to hear from
your opinions on the problem and proposed fix before going further.

My other concern is that why it isn't covered by a build-id cache.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/