linux-kernel - Re: [PATCH 2/2] serial: Add support for Fintek F81216A LPC to 4 UART

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPybu_1Ma+7nGaS0e17HpPcM1vk6ANSFN3C8MNR=JxWrBBmMOA@mail.gmail.com>
Date:	Thu, 31 Jul 2014 18:07:55 +0200
From:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
To:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.cz>, Alan Cox <alan@...ux.intel.com>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Murali Karicheri <m-karicheri2@...com>,
	Jingoo Han <jg1.han@...sung.com>,
	Michael Welling <mwelling@...e.org>,
	Peter Hurley <peter@...leysoftware.com>,
	Joe Schultz <jschultz@...-inc.com>,
	Ingo Molnar <mingo@...e.hu>,
	Doug Anderson <dianders@...omium.org>,
	linux-serial@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] serial: Add support for Fintek F81216A LPC to 4 UART

Hello Alan

> Less than ideal in some ways because the base may well be remapped by
> other hardware or on non x86 devices. No obvious ideas how to fix it
> though and PnP kind of implies x86.

If I extend the driver to consider other hw than x86 and PnP I will
definitely  look into this.

>
> On the bright side you can then make the resource layer do your locking
> work for you. We have an IORESOURCE_MUXED flag for these little horrors
> so you can request the resource with IORESOURCE_MUXED. If the resource is
> busy then you will get a failure back, if it is idle you will get the
> resource, if it is busy but held by another driver using IORESOURCE_MUXED
> then the request will block until they finish with it.

I was not aware of request_mutex, thanks for your help!. I am
preparing v2 with no mutex and requtest_mutex_region.

Thanks!

-- 
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/