linux-kernel - Re: [PATCH 1/2] serial/8250: Add support for RS485 IOCTLs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 31 Jul 2014 18:13:10 +0200
From:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
To:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.cz>, Alan Cox <alan@...ux.intel.com>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Murali Karicheri <m-karicheri2@...com>,
	Jingoo Han <jg1.han@...sung.com>,
	Michael Welling <mwelling@...e.org>,
	Peter Hurley <peter@...leysoftware.com>,
	Joe Schultz <jschultz@...-inc.com>,
	Ingo Molnar <mingo@...e.hu>,
	Doug Anderson <dianders@...omium.org>,
	linux-serial@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] serial/8250: Add support for RS485 IOCTLs

Hello Alan

> Is there any reasons we can't have uart_ops.rs485_config and the RS485
> ioctl logic in the serial_core, or even push rs485_get/put into the tty
> ioctl handler and tty ops so it's not duplicated everywhere ?

What about a step by step approach. First we add this code to the
8250_core, and then I remove all the specific driver
TIOCSRS485 handling and manage it through serial_core.c

Right now these are the drivers using it:

drivers/tty/serial/8250/8250_core.c:    case TIOCSRS485:
drivers/tty/serial/atmel_serial.c:      case TIOCSRS485:
drivers/tty/serial/crisv10.c:   case TIOCSRS485:
drivers/tty/serial/max310x.c:   case TIOCSRS485:
drivers/tty/serial/mcf.c:       case TIOCSRS485: {
drivers/tty/serial/omap-serial.c:       case TIOCSRS485:
rivers/tty/serial/sc16is7xx.c: case TIOCSRS485:

Regards!



-- 
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/