linux-kernel - Re: [PATCH - V2] VFS: allow ->d_manage() to declare -EISDIR in rcu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140804085731.GP18016@ZenIV.linux.org.uk>
Date:	Mon, 4 Aug 2014 09:57:31 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	NeilBrown <neilb@...e.de>
Cc:	Christoph Hellwig <hch@...radead.org>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	Ian Kent <raven@...maw.net>, autofs@...r.kernel.org,
	lkml <linux-kernel@...r.kernel.org>,
	Randy Dunlap <rdunlap@...radead.org>,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH - V2] VFS: allow ->d_manage() to declare -EISDIR in
 rcu_walk mode.

On Mon, Aug 04, 2014 at 05:06:29PM +1000, NeilBrown wrote:
> 
> In REF-walk mode, ->d_manage can return -EISDIR to indicate
> that the dentry is not really a mount trap (or even a mount point)
> and that any mounts or any DCACHE_NEED_AUTOMOUNT flag should be
> ignored.
> 
> RCU-walk mode doesn't currently support this, so if there is a dentry
> with DCACHE_NEED_AUTOMOUNT set but which shouldn't be a mount-trap,
> lookup_fast() will always drop in REF-walk mode.
> 
> With this patch, an -EISDIR from ->d_manage will always cause mounts
> and automounts to be ignored, both in REF-walk and RCU-walk.

In queue.  Right now I'm trying to linearize the damn acct fixes from late
April, needed to get Eric's umount-on-rmdir series into the mix safely ;-/
Hopefully I'll have something pushable by Tuesday; your patch definitely
will be in the pile.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/