lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 4 Aug 2014 10:55:15 +0200 From: Vlastimil Babka <vbabka@...e.cz> To: Andrew Morton <akpm@...ux-foundation.org>, David Rientjes <rientjes@...gle.com> Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org, Vlastimil Babka <vbabka@...e.cz>, Joonsoo Kim <iamjoonsoo.kim@....com>, Michal Nazarewicz <mina86@...a86.com>, Naoya Horiguchi <n-horiguchi@...jp.nec.com>, Christoph Lameter <cl@...ux.com>, Rik van Riel <riel@...hat.com>, Mel Gorman <mgorman@...e.de>, Minchan Kim <minchan@...nel.org>, Zhang Yanfei <zhangyanfei@...fujitsu.com> Subject: [PATCH v6 04/13] mm, compaction: do not recheck suitable_migration_target under lock isolate_freepages_block() rechecks if the pageblock is suitable to be a target for migration after it has taken the zone->lock. However, the check has been optimized to occur only once per pageblock, and compact_checklock_irqsave() might be dropping and reacquiring lock, which means somebody else might have changed the pageblock's migratetype meanwhile. Furthermore, nothing prevents the migratetype to change right after isolate_freepages_block() has finished isolating. Given how imperfect this is, it's simpler to just rely on the check done in isolate_freepages() without lock, and not pretend that the recheck under lock guarantees anything. It is just a heuristic after all. Signed-off-by: Vlastimil Babka <vbabka@...e.cz> Reviewed-by: Zhang Yanfei <zhangyanfei@...fujitsu.com> Acked-by: Minchan Kim <minchan@...nel.org> Acked-by: Mel Gorman <mgorman@...e.de> Cc: Joonsoo Kim <iamjoonsoo.kim@....com> Cc: Michal Nazarewicz <mina86@...a86.com> Cc: Naoya Horiguchi <n-horiguchi@...jp.nec.com> Cc: Christoph Lameter <cl@...ux.com> Cc: Rik van Riel <riel@...hat.com> Acked-by: David Rientjes <rientjes@...gle.com> --- mm/compaction.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index 68803c8..9484a4f 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -276,7 +276,6 @@ static unsigned long isolate_freepages_block(struct compact_control *cc, struct page *cursor, *valid_page = NULL; unsigned long flags; bool locked = false; - bool checked_pageblock = false; cursor = pfn_to_page(blockpfn); @@ -307,18 +306,6 @@ static unsigned long isolate_freepages_block(struct compact_control *cc, if (!locked) break; - /* Recheck this is a suitable migration target under lock */ - if (!strict && !checked_pageblock) { - /* - * We need to check suitability of pageblock only once - * and this isolate_freepages_block() is called with - * pageblock range, so just check once is sufficient. - */ - checked_pageblock = true; - if (!suitable_migration_target(page)) - break; - } - /* Recheck this is a buddy page under lock */ if (!PageBuddy(page)) goto isolate_fail; -- 1.8.4.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists