linux-kernel - Re: checkpatch.pl report about "Missing blank line after declarations" in a structure definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1407165996.16152.75.camel@joe-AO725>
Date:	Mon, 04 Aug 2014 08:26:36 -0700
From:	Joe Perches <joe@...ches.com>
To:	Dotan Barak <dotanb@...lanox.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: checkpatch.pl report about "Missing blank line after
 declarations" in a structure definition

On Mon, 2014-08-04 at 15:19 +0000, Dotan Barak wrote:
> In our code (I take it as an example), we used  MLX5_DECLARE_DOORBELL_LOCK,
> So I guess that the regular expression that you mentioned will fail on it
> (because the "_" is not allowed to be repeated).
> 
> So, I would change it a little bit to allow people to use underscore as a word separator.
[]
> > Maybe:
> > 
> > (?:$Storage\s+)(?:[A-Z_][A-Z0-9]+_){0,2}(?:DEFINE|DECLARE)(?:_[A-Z0-9]+){1,2}

What I suggested should allow any of:

	DECLARE_FOO
	_FOO_DEFINE_BAR
	FOO_BAR_DEFINE_BAZ
	FOO_BAR_DECLARE_BAZ_QUX

where FOO/BAR/BAZ/QUX can also have digits

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/