linux-kernel - RE: [PATCH] X86/CPU: Avoid 100ms sleep for cpu offline during S3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Aug 2014 13:13:21 +0000
From:	"Lan, Tianyu" <tianyu.lan@...el.com>
To:	Borislav Petkov <bp@...en8.de>
CC:	"tglx@...utronix.de" <tglx@...utronix.de>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"hpa@...or.com" <hpa@...or.com>, "x86@...nel.org" <x86@...nel.org>,
	"toshi.kani@...com" <toshi.kani@...com>,
	"imammedo@...hat.com" <imammedo@...hat.com>,
	"jan.kiszka@...mens.com" <jan.kiszka@...mens.com>,
	"mingo@...nel.org" <mingo@...nel.org>,
	"huawei.libin@...wei.com" <huawei.libin@...wei.com>,
	"prarit@...hat.com" <prarit@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Brandt, Todd E" <todd.e.brandt@...el.com>
Subject: RE: [PATCH] X86/CPU: Avoid 100ms sleep for cpu offline  during S3

Have you tried my attached kernel config file? When someone reported
the issue to me, I also was very hard to reproduce the issue by my own config
file. Maybe once 100 tries. But I can reproduced the issue every time with
the attached configure file on several my machines and even on server.

-----Original Message-----
From: Borislav Petkov [mailto:bp@...en8.de] 
Sent: Wednesday, August 06, 2014 7:08 PM
To: Lan, Tianyu
Cc: tglx@...utronix.de; mingo@...hat.com; hpa@...or.com; x86@...nel.org; toshi.kani@...com; imammedo@...hat.com; jan.kiszka@...mens.com; mingo@...nel.org; huawei.libin@...wei.com; prarit@...hat.com; linux-kernel@...r.kernel.org; Brandt, Todd E
Subject: Re: [PATCH] X86/CPU: Avoid 100ms sleep for cpu offline during S3

On Tue, Aug 05, 2014 at 05:29:18PM +0800, Lan Tianyu wrote:
> I think you can pull Tod's tool from git hub and do test from your 
> laptop. I attached a configure file come from ubuntu which is easier 
> to produce the issue. You can use it to reproduce the issue.

Right, so I ran it on an old dualcore AMD laptop I have lying around here and it didn't show any difference with or without your patch.

For all 4 runs I did with the tool running it without any arguments (so it did the default thing), I got suspend time for CPU1 of 4-6 msec and resume of ~20msec.

I don't know whether it is the dual core or AMD but your patch doesn't change anything on that laptop which is ok, I'd guess.

> Ok. BTW, I have tested it on the Ivbridge and Haswell machines.

Yeah, add those numbers to the commit message too.

Thanks.

--
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--