linux-kernel - Re: [PATCH] Staging: comedi: comedidev.h: fix checkpatch code style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1407292275.16152.115.camel@joe-AO725>
Date:	Tue, 05 Aug 2014 19:31:15 -0700
From:	Joe Perches <joe@...ches.com>
To:	Dzonatans Melgalvis <dz.melgalvis@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: comedi: comedidev.h: fix checkpatch code style
 issue

On Wed, 2014-08-06 at 02:29 +0300, Dzonatans Melgalvis wrote:
> Fixing checkpatch warning - blank line missing after declaration.

These are false positives from a previous version
of checkpatch.  Please use the version in -next
instead.  No errors are reported with that version.

> Signed-off-by: Dzonatans Melgalvis <dz.melgalvis@...il.com>
> ---
>  drivers/staging/comedi/comedidev.h | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
> index 58e58a3..c9b7978 100644
> --- a/drivers/staging/comedi/comedidev.h
> +++ b/drivers/staging/comedi/comedidev.h
> @@ -57,6 +57,7 @@ struct comedi_subdevice {
>  	const unsigned int *maxdata_list;	/* list is channel specific */
>  
>  	const struct comedi_lrange *range_table;
> +
>  	const struct comedi_lrange *const *range_table_list;
>  
>  	unsigned int *chanlist;	/* driver-owned chanlist (not used) */
> @@ -207,8 +208,10 @@ struct comedi_async {
>  	struct comedi_cmd cmd;
>  	wait_queue_head_t wait_head;
>  	unsigned int cb_mask;
> +
>  	int (*inttrig)(struct comedi_device *dev, struct comedi_subdevice *s,
>  		       unsigned int x);
> +
>  };
>  
>  struct comedi_driver {
> @@ -216,13 +219,16 @@ struct comedi_driver {
>  
>  	const char *driver_name;
>  	struct module *module;
> +
>  	int (*attach)(struct comedi_device *, struct comedi_devconfig *);
>  	void (*detach)(struct comedi_device *);
>  	int (*auto_attach)(struct comedi_device *, unsigned long);
>  
>  	/* number of elements in board_name and board_id arrays */
>  	unsigned int num_names;
> +
>  	const char *const *board_name;
> +
>  	/* offset in bytes from one board name pointer to the next */
>  	int offset;
>  };



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/