linux-kernel - Re: [PATCH 1/1] spi: Remove unused definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140806191430.GA5711@roeck-us.net>
Date:	Wed, 6 Aug 2014 12:14:30 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Greg KH <greg@...ah.com>
Cc:	Nick Krause <xerofoiffy@...il.com>,
	Richard Weinberger <richard.weinberger@...il.com>,
	Mark Brown <broonie@...nel.org>,
	"open list:SPI SUBSYSTEM" <linux-spi@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] spi: Remove unused definitions

On Wed, Aug 06, 2014 at 11:33:19AM -0700, Greg KH wrote:
> On Wed, Aug 06, 2014 at 01:53:17PM -0400, Nick Krause wrote:
> > Remove unused definition which cause the following warnings
> > 
> > drivers/spi/spi-omap-100k.c:73:0: warning: "WRITE" redefined [enabled by default]
> > include/linux/fs.h:193:0: note: this is the location of the previous definition
> > drivers/spi/spi-omap-100k.c:74:0: warning: "READ" redefined [enabled by default]
> > include/linux/fs.h:192:0: note: this is the location of the previous definition
> > 
> > Signed-off-by: Nick Krause <xerofoiffy@...il.com>
> > ---
> >  drivers/spi/spi-omap-100k.c | 4 ----
> >  1 file changed, 4 deletions(-)
> 
> Nick, you were warned about this numerous times in the past.
> 
> By changing email addresses you have now ensured that we will never
> listen to you, as you obviously are not listening to us.
> 
He does manage to get our attention, though. Also, it is not that simple -
for my part I keep looking out for the patches just to make sure that
we don't get any more less than well researched "fixes" into the kernel.
I figure it pays to spend some time now instead of having to clean up
the resulting mess if something slips by.

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/