linux-kernel - Re: [PATCH 1/1] spi: Remove unused definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140806193453.GJ17528@sirena.org.uk>
Date:	Wed, 6 Aug 2014 20:34:53 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Valdis Kletnieks <Valdis.Kletnieks@...edu>,
	Nick Krause <xerofoiffy@...il.com>,
	Richard Weinberger <richard.weinberger@...il.com>,
	"open list:SPI SUBSYSTEM" <linux-spi@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 1/1] spi: Remove unused definitions

On Wed, Aug 06, 2014 at 08:50:15PM +0200, Geert Uytterhoeven wrote:

> To be 100% sure, I tried to find with which kernel config this warning shows up.
> It doesn't happen for omap1_defconfig with CONFIG_SPI_OMAP_100K,
> which was the most likely culprit.

> It does happen with sparc/sparc64 allmodconfig. However, changing or
> removing the READ and WRITE definitions in drivers/spi/spi-omap-100k.c
> doesn't have any influence on the preprocessed source files
> ("make drivers/spi/spi-omap-100k.i", modulo line number changes),
> for both omap1 and sparc builds.

> (Nick: I believe the above is what people really want to see)

> So I conclude they are really not used, and they can be safely removed.

> Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Right, I'd already done the same analysis myself with looking for uses
myself (though I didn't go looking for how to trigger).  Nick, please do
look at the analysis Geert provided above - it is indeed exactly the
sort of thing that people would want to see, just saying what's in the
diff isn't enough especially given the well advertised quality problems
with your submissions.  You really need to explain why the change you're
making is a good idea.

I've applied the change.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)