linux-kernel - Re: [PATCH 3/4] mfd: imanager2: Add Core supports for IT8516/18/28

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140807100139.GE10136@lee--X1>
Date:	Thu, 7 Aug 2014 11:01:39 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Wei-Chun Pan <weichun.pan@...antech.com.tw>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	Jean Delvare <jdelvare@...e.de>,
	Guenter Roeck <linux@...ck-us.net>,
	Wolfram Sang <wsa@...-dreams.de>,
	"Louis.Lu" <Louis.Lu@...antech.com.tw>,
	"Neo.Lo" <neo.lo@...antech.com.tw>,
	"Hank.Peng" <Hank.Peng@...antech.com.tw>,
	"Kevin.Ong" <Kevin.Ong@...antech.com.tw>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] mfd: imanager2: Add Core supports for IT8516/18/28

You've replied to this email as an independent message, so now there
is little context.  When you reply, please ensure your mailer replies
to the thread.

On Thu, 07 Aug 2014, Wei-Chun Pan wrote:
> I have a question for your comment. As your mail,
> 
> > > +
> > > +static void __exit imanager2_mfd_device_exit(void) {
> > > +	mfd_remove_devices(&ec_pdev->dev);
> > > +	platform_device_unregister(ec_pdev);
> > > +}
> > > +
> > > +module_init(imanager2_mfd_device_init);
> > > +module_exit(imanager2_mfd_device_exit);
> > 
> > This is a mess.  Use module_platform_driver() instead.
> > 
> > > +MODULE_AUTHOR("Richard Vidal-Dorsch <richard.dorsch at
> > > +advantech.com>");
> > > +MODULE_DESCRIPTION("iManager2 platform device definitions v"
> > > +DRV_VERSION); MODULE_LICENSE("GPL"); MODULE_VERSION(DRV_VERSION);
> > 
> 
> How can I use module_platform_driver() and my driver exit function also can do
> mfd_remove_devices().
> Or any other better function install of mfd_remove_devices()?

That's the point - you don't do mfd_remove_devices() in exit(), you do
mfd_add_devices() in .probe() and mfd_remove_devices() in .remove().

The only thing you want to do in init() is platform_driver_register(),
or even better - don't have init() and exit() calls and use use
module_platform_driver_probe() instead.

> Signed-off-by: Wei-Chun Pan <weichun.pan@...antech.com.tw>

Not sure why you've signed-off on an email?

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/