linux-kernel - Re: [PATCH v2 1/2] tty: serial: 8250: Add Mediatek UART driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABuKBeKJ=KFc1DfvyHgD+iAC1=yLqYjjDUc0CH+1zbRQzw_DJw@mail.gmail.com>
Date:	Thu, 7 Aug 2014 16:07:41 +0200
From:	Matthias Brugger <matthias.bgg@...il.com>
To:	Alan Cox <alan@...ux.intel.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Randy Dunlap <rdunlap@...radead.org>,
	Greg KH <gregkh@...uxfoundation.org>, jslaby@...e.cz,
	Grant Likely <grant.likely@...aro.org>,
	Varka Bhadram <varkabhadram@...il.com>,
	Heiko Stübner <heiko@...ech.de>,
	Yingjoe Chen <yingjoe.chen@...il.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	linux-serial@...r.kernel.org
Subject: Re: [PATCH v2 1/2] tty: serial: 8250: Add Mediatek UART driver

2014-08-07 15:21 GMT+02:00 Alan Cox <alan@...ux.intel.com>:
>
>> +      * Some baudrates are not supported by the chip, so we use the next
>> +      * lower rate supported and update termios c_flag.
>
> I don't see the termios updating being done now ?

Please have a look on the usage of the SET_CFLAG_BAUD macro in the patch.
I'm not sure if it is the way to go though.

>
>> +     data->clk = of_clk_get(np, 0);
>> +     if (IS_ERR(data->clk)) {
>> +             pr_warn("Can't get timer clock");
>> +             return PTR_ERR(data->clk);
>> +     }
>> +
>> +     err = clk_prepare_enable(data->clk);
>> +     if (err) {
>> +             pr_warn("Can't prepare clock");
>
> and these do need a newline on them. They are also not very useful as
> they don't indicate what device was involved. If you passed pdev from
> mtk8250_probe you'd be able to use dev_warn instead
>
> Otherwise looks great and exactly as 8250_core is intended to be used.
>
> Alan
>
>



-- 
motzblog.wordpress.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/