linux-kernel - Re: [PATCH v2 1/2] tty: serial: 8250: Add Mediatek UART driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140807193512.1825b291@alan.etchedpixels.co.uk>
Date:	Thu, 7 Aug 2014 19:35:12 +0100
From:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
To:	Matthias Brugger <matthias.bgg@...il.com>
Cc:	Alan Cox <alan@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Randy Dunlap <rdunlap@...radead.org>,
	Greg KH <gregkh@...uxfoundation.org>, jslaby@...e.cz,
	Grant Likely <grant.likely@...aro.org>,
	Varka Bhadram <varkabhadram@...il.com>,
	Heiko Stübner <heiko@...ech.de>,
	Yingjoe Chen <yingjoe.chen@...il.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	linux-serial@...r.kernel.org
Subject: Re: [PATCH v2 1/2] tty: serial: 8250: Add Mediatek UART driver

On Thu, 7 Aug 2014 16:07:41 +0200
Matthias Brugger <matthias.bgg@...il.com> wrote:

> 2014-08-07 15:21 GMT+02:00 Alan Cox <alan@...ux.intel.com>:
> >
> >> +      * Some baudrates are not supported by the chip, so we use the next
> >> +      * lower rate supported and update termios c_flag.
> >
> > I don't see the termios updating being done now ?
> 
> Please have a look on the usage of the SET_CFLAG_BAUD macro in the patch.
> I'm not sure if it is the way to go though.

Ah missed that - no it's not the right way to go. From
8250_core:serial8250_do_set_termios() do

        /* Don't rewrite B0 */
        if (tty_termios_baud_rate(termios))
                tty_termios_encode_baud_rate(termios, baud, baud);


which will encoding the baud rate correctly for all cases, and where
possible encode it in the old style format rather than using BOTHER
(which old old apps cannot handle)

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/