linux-kernel - Re: [PATCH] ASoC: wm8962: Correct the bit offset to enable mono speaker output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140807165836.GL17528@sirena.org.uk>
Date:	Thu, 7 Aug 2014 17:58:36 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Nicolin Chen <nicoleotsuka@...il.com>
Cc:	patches@...nsource.wolfsonmicro.com, alsa-devel@...a-project.org,
	rf@...nsource.wolfsonmicro.com, lgirdwood@...il.com,
	linux-kernel@...r.kernel.org, tiwai@...e.de, perex@...ex.cz,
	ckeepax@...nsource.wolfsonmicro.com, B18700@...escale.com,
	b02247@...escale.com
Subject: Re: [PATCH] ASoC: wm8962: Correct the bit offset to enable mono
 speaker output

On Thu, Aug 07, 2014 at 07:55:49PM +0800, Nicolin Chen wrote:
> As WM8962 datasheet describes for SPK_MONO bit of R51: When SPK_MONO
> is set to '1', both speakers output the signal from the left channel.

> So for mono speaker widget, we shall enable Left Channel whose enable
> bit is 6 instead of 7 (Right Channel).
> 
> This patches just simply corrects the bit offset.

>  		   spkmixl, ARRAY_SIZE(spkmixl)),
>  SND_SOC_DAPM_MUX_E("Speaker PGA", WM8962_PWR_MGMT_2, 4, 0, &spkoutl_mux,
>  		   out_pga_event, SND_SOC_DAPM_POST_PMU),
> -SND_SOC_DAPM_PGA("Speaker Output", WM8962_CLASS_D_CONTROL_1, 7, 0, NULL, 0),
> +SND_SOC_DAPM_PGA("Speaker Output", WM8962_CLASS_D_CONTROL_1, 6, 0, NULL, 0),
>  SND_SOC_DAPM_OUTPUT("SPKOUT"),
>  };

Someone who's name I'd need to look up submitted an identical fix off
list recently - I checked the datasheet and it seems that in mono mode
the speaker output actually wants both left and right channels active so
there is a bug here but this isn't the fix.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)