linux-kernel - Re: [PATCH 1/4] umem: fix error return code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 07 Aug 2014 17:41:29 -0400
From:	Jeff Moyer <jmoyer@...hat.com>
To:	Julia Lawall <Julia.Lawall@...6.fr>
Cc:	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 1/4] umem: fix error return code

Julia Lawall <Julia.Lawall@...6.fr> writes:

> diff --git a/drivers/block/umem.c b/drivers/block/umem.c
> index 4cf81b5..371e819 100644
> --- a/drivers/block/umem.c
> +++ b/drivers/block/umem.c
> @@ -881,6 +881,7 @@ static int mm_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
>  	if (card->mm_pages[0].desc == NULL ||
>  	    card->mm_pages[1].desc == NULL) {
>  		dev_printk(KERN_ERR, &card->dev->dev, "alloc failed\n");
> +		ret = -ENOMEM;
>  		goto failed_alloc;
>  	}
>  	reset_page(&card->mm_pages[0]);
> @@ -891,8 +892,10 @@ static int mm_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
>  	card->biotail = &card->bio;
>  
>  	card->queue = blk_alloc_queue(GFP_KERNEL);
> -	if (!card->queue)
> +	if (!card->queue) {
> +		ret = -ENOMEM;
>  		goto failed_alloc;
> +	}

Reviewed-by: Jeff Moyer <jmoyer@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/