linux-kernel - Re: [PATCH 2/4] gdrom: fix error return code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 07 Aug 2014 17:41:54 -0400
From:	Jeff Moyer <jmoyer@...hat.com>
To:	Julia Lawall <Julia.Lawall@...6.fr>
Cc:	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 2/4] gdrom: fix error return code

Julia Lawall <Julia.Lawall@...6.fr> writes:

> diff --git a/drivers/cdrom/gdrom.c b/drivers/cdrom/gdrom.c
> index 584bc31..46ecd95 100644
> --- a/drivers/cdrom/gdrom.c
> +++ b/drivers/cdrom/gdrom.c
> @@ -807,16 +807,20 @@ static int probe_gdrom(struct platform_device *devptr)
>  	if (err)
>  		goto probe_fail_cmdirq_register;
>  	gd.gdrom_rq = blk_init_queue(gdrom_request, &gdrom_lock);
> -	if (!gd.gdrom_rq)
> +	if (!gd.gdrom_rq) {
> +		err = -ENOMEM;
>  		goto probe_fail_requestq;
> +	}
>  
>  	err = probe_gdrom_setupqueue();
>  	if (err)
>  		goto probe_fail_toc;
>  
>  	gd.toc = kzalloc(sizeof(struct gdromtoc), GFP_KERNEL);
> -	if (!gd.toc)
> +	if (!gd.toc) {
> +		err = -ENOMEM;
>  		goto probe_fail_toc;
> +	}

Reviewed-by: Jeff Moyer <jmoyer@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/