linux-kernel - Re: [PATCH] Staging: rtl8192u: fix sparse warnings in r8192U

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Aug 2014 22:35:30 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	A Raghavendra Rao <raghav3276@...il.com>
Cc:	peter.p.waskiewicz.jr@...el.com, c@...io,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	A Raghavendra Rao <arrao@...c.in>
Subject: Re: [PATCH] Staging: rtl8192u: fix sparse warnings in r8192U_core.c

On Thu, Aug 07, 2014 at 10:10:47AM +0530, A Raghavendra Rao wrote:
> Fix the following sparse warnings:
> drivers/staging/rtl8192u/r8192U_core.c:670:6: warning: symbol 'dump_eprom'
> was not declared. Should it be static?
> drivers/staging/rtl8192u/r8192U_core.c:1556:14: warning: symbol
> 'txqueue2outpipe' was not declared. Should it be static?
> drivers/staging/rtl8192u/r8192U_core.c:4876:5: warning: symbol
> 'GetRxPacketShiftBytes819xUsb' was not declared. Should it be static?
> 
> Signed-off-by: A Raghavendra Rao <arrao@...c.in>
> ---
>  drivers/staging/rtl8192u/r8192U_core.c |   16 +++++++++++-----
>  1 file changed, 11 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
> index 7640386..6ad767a 100644
> --- a/drivers/staging/rtl8192u/r8192U_core.c
> +++ b/drivers/staging/rtl8192u/r8192U_core.c
> @@ -667,12 +667,14 @@ static void tx_timeout(struct net_device *dev)
>  
>  
>  /* this is only for debug */
> -void dump_eprom(struct net_device *dev)
> +#ifdef DEBUG_EPROM

You can't define this, so just delete the whole thing.

Wait, didn't someone already do this?  Yes, someone just sent me this
same thing on the 1st, it's in my queue to apply after 3.17-rc1 is out.

Sorry, I can't take this.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/