linux-kernel - Re: [PATCH] rtl8150: Check if RSR is already defined

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140806.223611.1134627526934618200.davem@davemloft.net>
Date:	Wed, 06 Aug 2014 22:36:11 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	xerofoiify@...il.com
Cc:	petkan@...leusys.com, linux-usb@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtl8150: Check if RSR is already defined

From: Nick Krause <xerofoiify@...il.com>
Date: Thu,  7 Aug 2014 07:24:54 +0200

> I am getting the following warn
> 
> drivers/net/usb/rtl8150.c:30:0: warning: "RSR" redefined
> arch/xtensa/include/asm/processor.h:189:0: note: this is the location of the previous definition
> 
> I wanted to remove RSR as it is not being used but it is not clear if being used
> for documenting purpose. undefining should be enough.
> 
> Signed-off-by: Nick Krause <xerofoify@...il.com>

This isn't the right way to fix this.

Rather, the thing to do is to give the macros in this driver an
appropriate prefix such as "RTL8150_" so that they don't collide
with things in the global namespace.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/